feat: add Promise.allKeyed and Promise.allSettledKeyed to esnext - #64093
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Open
feat: add Promise.allKeyed and Promise.allSettledKeyed to esnext#64093Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
Conversation
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
August 29, 2026 19:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ESNext typings for the Stage 3 keyed Promise combinators.
Changes:
- Adds
Promise.allKeyedandPromise.allSettledKeyeddeclarations. - Registers and embeds the new
esnext.promiselibrary. - Adds compiler coverage and updates generated baselines.
Reviewed changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/bundled/embed_generated.go |
Embeds the new library. |
tsc/internal/bundled/libs/lib.esnext.d.ts |
References esnext.promise. |
tsc/internal/bundled/libs/lib.esnext.promise.d.ts |
Declares the new APIs. |
tsc/internal/bundled/libs_generated.go |
Registers the bundled library. |
tsc/internal/compiler/program_test.go |
Adds it to expected ESNext libraries. |
tsc/internal/tsoptions/enummaps.go |
Maps the esnext.promise option. |
tsc/testdata/baselines/reference/compiler/libReplacement(libreplacement=true).trace.json |
Updates replacement resolution trace. |
tsc/testdata/baselines/reference/compiler/promiseAllKeyed.js |
Records test emit. |
tsc/testdata/baselines/reference/compiler/promiseAllKeyed.symbols |
Records inferred symbols. |
tsc/testdata/baselines/reference/compiler/promiseAllKeyed.types |
Records inferred types. |
tsc/testdata/baselines/reference/tsc/commandLine/help-all.js |
Updates library help output. |
tsc/testdata/baselines/reference/tsc/commandLine/help.js |
Updates library help output. |
tsc/testdata/baselines/reference/tsc/commandLine/show-help-with-ExitStatus.DiagnosticsPresent_OutputsSkipped-when-host-cannot-provide-terminal-width.js |
Updates help baseline. |
tsc/testdata/baselines/reference/tsc/commandLine/show-help-with-ExitStatus.DiagnosticsPresent_OutputsSkipped.js |
Updates help baseline. |
tsc/testdata/baselines/reference/tsc/ignoreConfig/without-any-options-when-config-file-absent-with---ignoreConfig.js |
Updates library listing. |
tsc/testdata/baselines/reference/tsc/ignoreConfig/without-any-options-when-config-file-absent.js |
Updates library listing. |
tsc/testdata/baselines/reference/tscWatch/commandLine/Parse-watch-interval-option-without-tsconfig.json.js |
Updates watch help baseline. |
tsc/testdata/baselines/reference/tscWatch/commandLineWatch/watch-handles-tsconfig-deleted.js |
Updates watch help baseline. |
tsc/testdata/tests/cases/compiler/promiseAllKeyed.ts |
Tests inference, symbols, thenables, and invalid inputs. |
Files not reviewed (2)
- tsc/internal/bundled/embed_generated.go: Generated file
- tsc/internal/bundled/libs_generated.go: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
typescript-automation
Bot
added
the
For Milestone Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
feat/63701
branch
from
August 31, 2026 21:18
688f929 to
064cbf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63701